test: Add checkpoints for PouchRunBlkioSuite #2291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2291 +/- ##
=========================================
+ Coverage 66.75% 66.8% +0.04%
=========================================
Files 208 208
Lines 16971 16971
=========================================
+ Hits 11329 11337 +8
+ Misses 4275 4270 -5
+ Partials 1367 1364 -3
|
|
|
chuanchang
force-pushed
the
add_checkpoints_for_PouchRunBlkioSuite
branch
2 times, most recently
from
d6319df to
d847b5d
Compare
chuanchang
changed the title
Contributor
|
basically, LGTM. But please rebase the commits into one 😄 |
Contributor
|
please check the error |
test.util.util: add new GetMajMinNumofDevice function to get
major:minor device number
test.cli_run_blkio_test: add host and container checkpoints
Signed-off-by: Alex Jia <[email protected]>
chuanchang
force-pushed
the
add_checkpoints_for_PouchRunBlkioSuite
branch
from
d847b5d to
1e36dc8
Compare
Contributor
Author
|
@fuweid done, thanks for reviewing, and v2 patch is coming. |
allencloud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add new checkpoints and make sure cgroup setting is valid in inspect of container, configuration of host and the container.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
$ go test -test.v -check.f PouchRunBlkioSuite
=== RUN Test
OK: 3 passed
--- PASS: Test (24.99s)
PASS
ok github.com/alibaba/pouch/test 25.103s
Ⅴ. Special notes for reviews